Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RQ to control SSE stream retries #82

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

gordonhart
Copy link
Member

Use the same retry/control mechanism that is used for other fetches (React-Query's useQuery handling) for event source stream fetches, rather than the retry mechanism built into fetchEventSource.

@gordonhart gordonhart enabled auto-merge (squash) September 19, 2024 21:27
@gordonhart gordonhart merged commit bd8eec9 into trunk Sep 19, 2024
11 checks passed
@gordonhart gordonhart deleted the gh/limit-sse-retries branch September 19, 2024 21:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (d01796d) to head (e978b77).
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk      #82   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          33       33           
  Lines        1426     1426           
=======================================
  Hits         1381     1381           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants