Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download CSVs with auth headers when present #83

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

gordonhart
Copy link
Member

Also improve the UX a bit by showing a loading spinner when the response is pending.

@gordonhart gordonhart enabled auto-merge (squash) September 19, 2024 22:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (bd8eec9) to head (252bc25).

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk      #83      +/-   ##
==========================================
- Coverage   96.84%   96.82%   -0.02%     
==========================================
  Files          33       33              
  Lines        1426     1419       -7     
==========================================
- Hits         1381     1374       -7     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonhart gordonhart merged commit a8b3706 into trunk Sep 19, 2024
11 checks passed
@gordonhart gordonhart deleted the gh/download-with-auth branch September 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants