Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid compatibility issue with numpy 2.0 #622

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

yifanwu-kolena
Copy link
Contributor

@yifanwu-kolena yifanwu-kolena commented Jun 17, 2024

Linked issue(s)

What change does this PR introduce and why?

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@yifanwu-kolena yifanwu-kolena requested a review from a team as a code owner June 17, 2024 21:05
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (b18bdeb) to head (07923cb).

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #622      +/-   ##
==========================================
- Coverage   94.52%   93.60%   -0.92%     
==========================================
  Files          86       86              
  Lines        5349     5349              
  Branches      777      777              
==========================================
- Hits         5056     5007      -49     
- Misses        217      256      +39     
- Partials       76       86      +10     
Flag Coverage Δ
integration 75.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yifanwu-kolena yifanwu-kolena merged commit 263325e into trunk Jun 17, 2024
33 checks passed
@yifanwu-kolena yifanwu-kolena deleted the yifan/numpy-2 branch June 17, 2024 21:20
@bagalaster bagalaster mentioned this pull request Jun 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants