Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator to send data to kolena #648

Conversation

grant-Kolena
Copy link
Contributor

@grant-Kolena grant-Kolena commented Jul 16, 2024

What change does this PR introduce and why?

additional documentation added
Screenshot 2024-07-18 at 1 59 19 PM

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@grant-Kolena grant-Kolena changed the title decorator to send data to kolena [WIP]decorator to send data to kolena Jul 16, 2024
@grant-Kolena grant-Kolena marked this pull request as ready for review July 17, 2024 16:00
@grant-Kolena grant-Kolena requested a review from a team as a code owner July 17, 2024 16:00
@grant-Kolena grant-Kolena changed the title [WIP]decorator to send data to kolena Decorator to send data to kolena Jul 17, 2024
@grant-Kolena grant-Kolena force-pushed the grant/kol-6902-mbt-track-experiments-in-kolena-in-a-similar-fashion-to branch from 9cd309b to 2adc313 Compare July 18, 2024 17:33
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 73.54839% with 41 lines in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (eed86b6) to head (c1fdd70).

Files Patch % Lines
kolena/_experimental/trace/trace.py 72.66% 36 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #648      +/-   ##
==========================================
- Coverage   94.26%   93.67%   -0.60%     
==========================================
  Files          88       90       +2     
  Lines        5457     5610     +153     
  Branches      798      830      +32     
==========================================
+ Hits         5144     5255     +111     
- Misses        233      270      +37     
- Partials       80       85       +5     
Flag Coverage Δ
integration 76.29% <72.25%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant-Kolena grant-Kolena requested a review from ly-kolena July 18, 2024 18:40
@grant-Kolena grant-Kolena force-pushed the grant/kol-6902-mbt-track-experiments-in-kolena-in-a-similar-fashion-to branch from 481c750 to 2cda724 Compare July 19, 2024 19:40
@kolenaIO kolenaIO deleted a comment from grant81 Jul 22, 2024
@grant-Kolena grant-Kolena force-pushed the grant/kol-6902-mbt-track-experiments-in-kolena-in-a-similar-fashion-to branch from 1edf886 to 09b80a6 Compare July 22, 2024 19:00
@@ -16,7 +16,7 @@
from typing import List
from typing import Optional

from pydantic.dataclasses import dataclass
from pydantic.v1.dataclasses import dataclass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@grant-Kolena grant-Kolena merged commit 497ae64 into trunk Jul 23, 2024
57 checks passed
@grant-Kolena grant-Kolena deleted the grant/kol-6902-mbt-track-experiments-in-kolena-in-a-similar-fashion-to branch July 23, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants