Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box metadata docs #696

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Bounding box metadata docs #696

merged 17 commits into from
Oct 18, 2024

Conversation

grant-Kolena
Copy link
Contributor

Linked issue(s)

What change does this PR introduce and why?

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@grant-Kolena
Copy link
Contributor Author

@mkaramlou to take over this doc task

@grant-Kolena grant-Kolena changed the title wip commit for bounding box metadata docs [WIP] bounding box metadata docs Sep 25, 2024
@mkaramlou mkaramlou marked this pull request as ready for review October 9, 2024 17:05
@mkaramlou mkaramlou requested a review from a team as a code owner October 9, 2024 17:05
@mkaramlou mkaramlou enabled auto-merge (squash) October 9, 2024 18:36
@munkyshi munkyshi changed the title [WIP] bounding box metadata docs Bounding box metadata docs Oct 10, 2024
mkaramlou and others added 12 commits October 11, 2024 11:19
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
Co-authored-by: Andrew Shi <andrew@kolena.io>
@munkyshi
Copy link
Contributor

Looks like some links are broken now:

docs/automations/extract-bounding-box-metadata.md:50:3 MD051/link-fragments Link fragments should be valid [Context: "[Mean Relative Distance To Image Centre](#mean-relative-distance-to-image-centre)"]
docs/automations/extract-bounding-box-metadata.md:54:3 MD051/link-fragments Link fragments should be valid [Context: "[Std Relative Distance To Image Centre](#std-relative-distance-to-image-centre)"]


| Feature Name | Brief Description | Property Type |
|-----------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------|----------------------------|
| [Aspect Ratio](#aspect-ratio) | The aspect ratio of the bounding box (`width / height`) | Bounding Box Property |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove aspect ratio. I don't have this as a configurable extraction because we add it when creating bbox annotations using the SDK

@mkaramlou mkaramlou merged commit 368df4c into trunk Oct 18, 2024
32 checks passed
@mkaramlou mkaramlou deleted the grant/kol-7414-documentation branch October 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants