Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add custom annotation class #698

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

nankolena
Copy link
Contributor

Linked issue(s)

Resolves KOL-7552

What change does this PR introduce and why?

Created a class for custom annotation. See this comment for verification steps.

Screenshots of generated API ref:
image

image

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@millerpeterson
Copy link
Contributor

Should there be some additional general indication that additional fields might be present on the objects depending on kind?

@nankolena
Copy link
Contributor Author

Should there be some additional general indication that additional fields might be present on the objects depending on kind?

Technically in the case of bev, we do need the locator field. I intentionally left it generic with Please reach out to the Kolena team for support if you need custom annotations because the immediate implementation is for a specific customer and did not want to give the expectations that it will work out of the box for everyone if they use the same kind. Let me know what you think on this

@millerpeterson
Copy link
Contributor

I intentionally left it generic with Please reach out to the Kolena team for support if you need custom annotations because the immediate implementation is for a specific customer and did not want to give the expectations that it will work out of the box for everyone if they use the same kind.

Yeah that makes sense to me 👍

@nankolena nankolena merged commit dcb050e into trunk Oct 3, 2024
57 checks passed
@nankolena nankolena deleted the nan/kol-7552-be-support branch October 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants