Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for dataset upsert #704

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

nankolena
Copy link
Contributor

@nankolena nankolena commented Oct 7, 2024

Linked issue(s)

Resolves KOL-7432

What change does this PR introduce and why?

Add tests for upsert behavior when uploading a dataset with append_only=True. Expected CI to fail before https://github.com/kolenaIO/shipyard/pull/2473 is in production, but have successfully tested against local server.

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@nankolena nankolena marked this pull request as ready for review October 9, 2024 15:50
@nankolena nankolena requested a review from a team as a code owner October 9, 2024 15:50
Copy link
Contributor

@munkyshi munkyshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nankolena nankolena merged commit f6d47b4 into trunk Oct 11, 2024
32 checks passed
@nankolena nankolena deleted the nan/kol-7432-add-test branch October 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants