Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic example for polygon-based instance segmentation in datasets #710

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

munkyshi
Copy link
Contributor

Linked issue(s)

N/A

What change does this PR introduce and why?

Add basic example for polygon-based instance segmentation in datasets

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@munkyshi munkyshi requested a review from a team as a code owner October 11, 2024 19:01
@munkyshi munkyshi force-pushed the andrew/instance-seg-example branch from 6a2a9c7 to c8a6dc6 Compare October 11, 2024 19:29
@munkyshi munkyshi enabled auto-merge (squash) October 11, 2024 19:30
Comment on lines +13 to +14
"s3fs>=2023.5.0,<2024",
"fsspec>=2023.5.0,<2024",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking - I noticed similar pattern in other examples too that capped the versions for these, do you remember the rationale for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, had an auto-merge on -- this was basically to match the effect of poetry capping the major version with ^2023.5.0 -- I suppose in this case, the major version doesn't necessarily mean an API break, and it's safe to leave these uncapped, but I didn't change it to keep consistent with OD.

@munkyshi munkyshi merged commit 3b05174 into trunk Oct 11, 2024
55 of 57 checks passed
@munkyshi munkyshi deleted the andrew/instance-seg-example branch October 11, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants