Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Auto Fishing - Estate.xml #56

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Create Auto Fishing - Estate.xml #56

merged 2 commits into from
Apr 14, 2024

Conversation

The-Synthax
Copy link
Contributor

@The-Synthax The-Synthax commented Mar 7, 2024 •
edited by kpreisser
Loading

(See previous PR: #33)

Fixes #29

kpreisser
kpreisser reviewed Mar 10, 2024
View reviewed changes
Copy link
Owner

@kpreisser kpreisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, it looks great! I have some comments about the individual steps.

Are you okay with me editing the file contents based on my comments?
Thanks!

@The-Synthax
Copy link
Contributor Author

Thank you for this PR, it looks great! I have some comments about the individual steps.

Are you okay with me editing the file contents based on my comments? Thanks!

Yes totally, go ahead. I haven't played in quite some time and don't entirely recall my reasoning for certain things here.

@kpreisser
Minor improvements to estate fishing:
f081835 
- Use a loop with count 19, and then a straight cast (to align the toon with the fisherman).
- Improve key press durations and pause times.
- Improve scan color values.
kpreisser
kpreisser approved these changes Apr 14, 2024
View reviewed changes
Copy link
Owner

@kpreisser kpreisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I applied the proposed changes and will merge the PR.

@kpreisser kpreisser merged commit f8f8996 into kpreisser:main Apr 14, 2024
This was referenced Apr 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpreisser kpreisser kpreisser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Estate Pond?
2 participants
@The-Synthax @kpreisser