-
Notifications
You must be signed in to change notification settings - Fork 304
add az pipepline yaml #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -9,7 +9,8 @@ | |||
<PackageIconUrl>https://raw.githubusercontent.com/kubernetes/kubernetes/master/logo/logo.png</PackageIconUrl> | |||
<PackageTags>kubernetes;docker;containers;</PackageTags> | |||
|
|||
<TargetFrameworks>netstandard1.4;net452;netcoreapp2.1;xamarinios10;monoandroid81</TargetFrameworks> | |||
<TargetFrameworks>netstandard1.4;net452;netcoreapp2.1</TargetFrameworks> | |||
<!-- <TargetFrameworks>netstandard1.4;net452;netcoreapp2.1;xamarinios10;monoandroid81</TargetFrameworks> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still people interested in this for xamarin, can we retain it for xamarin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure pipeline windows image does not have ios sdk on it. Build will fail only on CI.
My idea is to create another issue for it and ping Azure pipeline team.
@@ -20,7 +21,6 @@ | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Microsoft.AspNetCore.JsonPatch" Version="1.1.2" /> | |||
<PackageReference Include="Nerdbank.GitVersioning" Version="2.2.33" PrivateAssets="all" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to azure pipeline versioning
- task: DotNetCoreCLI@2
displayName: 'dotnet pack'
inputs:
command: pack
packagesToPack: src/KubernetesClient/KubernetesClient.csproj
packDirectory: '$(Build.ArtifactStagingDirectory)/nupkg'
majorVersion: 1
minorVersion: 4
versioningScheme: byPrereleaseNumber
this will generate a SemVer -compliant version formatted as X.Y.Z-ci-datetime where you choose X, Y, and Z.
The pro for generating version when CI is that it differentiate build
and commit
.
Same commit
might be different due to build
environment changed.
I don't want to remove Xamarin support from the core project, perhaps we can use a script or conditional to adjust things in the pipeline build? |
@brendanburns fixed with conditional build. pipeline on azure will yield |
You should also be able to build Xamarin in Azure Pipelines, with an additional macOS build pipeline - https://docs.microsoft.com/en-us/azure/devops/pipelines/languages/xamarin?view=azure-devops |
That sounds good. Let's add a Mac build to the pipeline. |
If let me choose, I will choose netcore and net452 in our published nuget package matrix WinNT
MacOS
Ubuntu
build using mac os |
/lgtm @tg123 what do I need to do to set this up for real? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tg123 I finally got this setup started, but coverage is failing: https://dev.azure.com/kubernetes-client/csharp-build/_build/results?buildId=5 Any ideas? Thanks! |
https://dev.azure.com/kubernetes-client/csharp-build/_build/results?buildId=6 👍 we are programming by accident :P |
First step to enable Azure Pipeline
Example result
https://farmer1992.visualstudio.com/opensources/_build/results?buildId=270
Built on Windows, as a result, add targeting
net452
to nupkg.However,
xamarinios10
,monoandroid81
still cannot be included due to that ios/android sdk are not shipped with azure pipeline image.Need to create an instance for this report to enable azure pipeline