Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.4 Support Added #38

Merged
merged 5 commits into from
Jan 6, 2025
Merged

PHP8.4 Support Added #38

merged 5 commits into from
Jan 6, 2025

Conversation

cod43156
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

@cod43156
Copy link
Contributor Author

@froschdesign Could you kindly proceed with merging this PR if there are no further concerns? Thank you!

@cod43156
Copy link
Contributor Author

@froschdesign, just checking in to see if you've had a chance to review this PR. Could you kindly proceed with merging it if everything looks good? Thank you!

@nishant04412
Copy link

@gsteel Can you please review and let us know if this can be merged or anything needs to be addressed ?

@froschdesign
Copy link
Member

@nishant04412
It is absolutely not necessary to ask for reviews, because nothing will be overlooked. Please remember, we are only doing this in our spare time and there is still time before the official release of version 8.4.

@cod43156
Copy link
Contributor Author

@gsteel @froschdesign we understand things are busy, and reviews happen on your own time. Whenever you can, we'd appreciate a quick look to ensure we're on the right track. No worries if it's not immediate, just whenever it fits into your schedule!

@cod43156
Copy link
Contributor Author

cod43156 commented Jan 2, 2025

Hi @gsteel @froschdesign

Just wanted to gently follow up on the review request whenever you have the time.

Thank you so much for your support!

Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
@samsonasik
Copy link
Member

composer.lock needs to be regenerated

Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
@froschdesign froschdesign added this to the 2.18.0 milestone Jan 3, 2025
@samsonasik
Copy link
Member

Looks good, thank you @cod43156

@samsonasik samsonasik merged commit 84df304 into laminas:2.18.x Jan 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants