-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.4 Support Added #38
Conversation
cod43156
commented
Sep 30, 2024
Q | A |
---|---|
Documentation | yes/no |
Bugfix | yes/no |
BC Break | yes/no |
New Feature | yes/no |
RFC | yes/no |
QA | yes/no |
a783a70
to
bbb4cc0
Compare
@froschdesign Could you kindly proceed with merging this PR if there are no further concerns? Thank you! |
@froschdesign, just checking in to see if you've had a chance to review this PR. Could you kindly proceed with merging it if everything looks good? Thank you! |
@gsteel Can you please review and let us know if this can be merged or anything needs to be addressed ? |
@nishant04412 |
@gsteel @froschdesign we understand things are busy, and reviews happen on your own time. Whenever you can, we'd appreciate a quick look to ensure we're on the right track. No worries if it's not immediate, just whenever it fits into your schedule! |
Just wanted to gently follow up on the review request whenever you have the time. Thank you so much for your support! |
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
18fc5b9
to
1c478c9
Compare
Signed-off-by: Raj Mohan <cod43156@adobe.com>
composer.lock needs to be regenerated |
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Looks good, thank you @cod43156 |