New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifies the affected components (PDF Extractor and HTTP Executor) #15641

Open

chowyu12 wants to merge 2 commits into langgenius:main from chowyu12:main

+60 −49

chowyu12 commented Mar 12, 2025

Summary

In pdf_extractor.py:

Added nested try/finally blocks to ensure proper resource cleanup
Improved error handling for PDF document processing
Added proper cleanup for text_page and page objects
Ensured resources are released in the correct order: text_page → page → pdf_reader

In executor.py:

Added proper HTTP connection management using context managers
Improved file resource handling in binary data processing
Added response cleanup in error cases
Enhanced error handling with proper resource cleanup
Added connection pooling for better resource management

These changes address potential memory leaks by ensuring proper resource cleanup and improving error handling across both files.

zhouyy added 2 commits

March 12, 2025 18:00


          fix: properly close pdf reader resources in pdf_extractor

90d1226


          fix: properly handle resource cleanup in http request executor

b23c27b

dosubot bot added size:L 💪 enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement size:L