ADD: Optimization-based bound tightening utility #103
Conversation
There was a problem hiding this comment.
I only did a quick review but I will make the following suggestion.
If you can avoid having the min-width and precision differ based on the variable types, I think that would be greatly preferable. This will add quite a few parameters that a user might need to tune. Also note that the smallest possible values for these parameters that are still correct will vary based on optimality tolerance of the solver used for bound tightening; so if the user can specify that solver, they should also be able to provide a globally correct min-width and precision.
I'll also note that specifying the precision as prec::Int is convenient from an implementation standpoint, but I think it is less intuitive to a would be user. I would make this a 1e-x type of tolerance, which is a fairly standard approach for specifying tolerances.
.travis.yml
Outdated
| @@ -4,15 +4,15 @@ os: | |||
| - osx | |||
| julia: | |||
| - 1.0 | |||
| - 1.4 | |||
| - 1.5 | |||
There was a problem hiding this comment.
I recently learned we can use 1 to sick to the latest version of 1.x
|
I'll also suggest adding a note to the change log. :-) |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 84.78% 84.72% -0.06%
==========================================
Files 23 24 +1
Lines 1840 2108 +268
==========================================
+ Hits 1560 1786 +226
- Misses 280 322 +42
Continue to review full report at Codecov.
|
This adds a draft version of the optimization-based bound tightening utility. It also includes various bug fixes encountered during implementation of this utility.