Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Ensure short pipes with valves are reduced to just valves #113

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

tasseff
Copy link
Member

@tasseff tasseff commented Oct 12, 2020

@jjstickel, assuming this corrects the issue we were discussing, this should close #112. It doesn't ensure that all short pipes don't have adjacent valves, but it does ensure that when parsing EPANET files, we will not decompose a short-enough pipe with a valve into a short pipe and a valve.

If we want to pursue a more careful reduction of the network (e.g., ensure short pipes and valves never exist in sequence), I think this would be more easily facilitated by using a package that inspects the graph structure of the network (e.g., LightGraphs.jl).

@tasseff tasseff requested a review from jjstickel October 12, 2020 21:55
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #113 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   80.55%   80.85%   +0.30%     
==========================================
  Files          27       27              
  Lines        2206     2210       +4     
==========================================
+ Hits         1777     1787      +10     
+ Misses        429      423       -6     
Impacted Files Coverage Δ
src/io/epanet.jl 72.32% <100.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbe818...0b8abb9. Read the comment docs.

@tasseff tasseff merged commit 0b8abb9 into master Oct 13, 2020
@tasseff tasseff deleted the short-pipe-reduce branch October 13, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate pipes that are short with valves to just valves
1 participant