FIX: Ensure short pipes with valves are reduced to just valves #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jjstickel, assuming this corrects the issue we were discussing, this should close #112. It doesn't ensure that all short pipes don't have adjacent valves, but it does ensure that when parsing EPANET files, we will not decompose a short-enough pipe with a valve into a short pipe and a valve.
If we want to pursue a more careful reduction of the network (e.g., ensure short pipes and valves never exist in sequence), I think this would be more easily facilitated by using a package that inspects the graph structure of the network (e.g., LightGraphs.jl).