Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add per_unit keyword with io #142

Merged
merged 1 commit into from
Mar 14, 2022
Merged

add per_unit keyword with io #142

merged 1 commit into from
Mar 14, 2022

Conversation

jjstickel
Copy link
Collaborator

This small change enables the network to be read in without setting the network to per_unit = true. It is useful for creating visualizations.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #142 (3f29c4e) into master (ac81eda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          37       37           
  Lines        4058     4059    +1     
=======================================
+ Hits         3708     3709    +1     
  Misses        350      350           
Impacted Files Coverage Δ
src/io/common.jl 96.66% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac81eda...3f29c4e. Read the comment docs.

@jjstickel jjstickel requested a review from tasseff March 8, 2022 02:06
Copy link
Member

@tasseff tasseff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a good compromise for the moment. Thank you!

@tasseff tasseff merged commit cddbb97 into master Mar 14, 2022
@tasseff tasseff deleted the per_unit-false branch March 14, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants