Skip to content

[12.x] Enhance PHPDoc for Manager classes with @param-closure-this #55001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Illuminate/Auth/AuthManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ public function userResolver()
* Set the callback to be used to resolve users.
*
* @param \Closure $userResolver
* @param-closure-this $this $userResolver
* @return $this
*/
public function resolveUsersUsing(Closure $userResolver)
Expand All @@ -269,6 +270,7 @@ public function resolveUsersUsing(Closure $userResolver)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand All @@ -283,6 +285,7 @@ public function extend($driver, Closure $callback)
*
* @param string $name
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function provider($name, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Broadcasting/BroadcastManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ public function purge($name = null)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Cache/CacheManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ public function purge($name = null)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Filesystem/FilesystemManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ public function purge($name = null)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Log/LogManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ public function setDefaultDriver($name)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Mail/MailManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,7 @@ public function purge($name = null)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
2 changes: 2 additions & 0 deletions src/Illuminate/Queue/QueueManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ protected function getConnector($driver)
*
* @param string $driver
* @param \Closure $resolver
* @param-closure-this $this $resolver
* @return void
*/
public function extend($driver, Closure $resolver)
Expand All @@ -198,6 +199,7 @@ public function extend($driver, Closure $resolver)
*
* @param string $driver
* @param \Closure $resolver
* @param-closure-this $this $resolver
* @return void
*/
public function addConnector($driver, Closure $resolver)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Redis/RedisManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ public function purge($name = null)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Support/Manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ protected function callCustomCreator($driver)
*
* @param string $driver
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($driver, Closure $callback)
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Support/MultipleInstanceManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ public function purge($name = null)
*
* @param string $name
* @param \Closure $callback
* @param-closure-this $this $callback
* @return $this
*/
public function extend($name, Closure $callback)
Expand Down
10 changes: 10 additions & 0 deletions types/Managers/AuthManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php
declare(strict_types=1);

use Illuminate\Auth\AuthManager;
use function PHPStan\Testing\assertType;

$authManager = resolve(AuthManager::class);
$authManager->extend('token', function (): void {
assertType('Illuminate\Auth\AuthManager',$this);
});
10 changes: 10 additions & 0 deletions types/Managers/BroadcastManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php
declare(strict_types=1);

use \Illuminate\Broadcasting\BroadcastManager;
use function PHPStan\Testing\assertType;

$broadcastManager = resolve(BroadcastManager::class);
$broadcastManager->extend('reverb', function (): void {
assertType('Illuminate\Broadcasting\BroadcastManager',$this);
});
11 changes: 11 additions & 0 deletions types/Managers/CacheManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);

use Illuminate\Cache\CacheManager;

use function PHPStan\Testing\assertType;

$cacheManager = resolve(CacheManager::class);
$cacheManager->extend('redis', function (): void {
assertType('Illuminate\Cache\CacheManager',$this);
});
11 changes: 11 additions & 0 deletions types/Managers/ConcurrencyManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);


use Illuminate\Concurrency\ConcurrencyManager;
use function PHPStan\Testing\assertType;

$concurrencyManager = resolve(ConcurrencyManager::class);
$concurrencyManager->extend('custom', function (): void {
assertType('Illuminate\Concurrency\ConcurrencyManager', $this);
});
11 changes: 11 additions & 0 deletions types/Managers/FilesystemManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);


use Illuminate\Filesystem\FilesystemManager;
use function PHPStan\Testing\assertType;

$filesystemManager = resolve(FilesystemManager::class);
$filesystemManager->extend('local', function (): void {
assertType('Illuminate\Filesystem\FilesystemManager', $this);
});
11 changes: 11 additions & 0 deletions types/Managers/LogManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);


use Illuminate\Log\LogManager;
use function PHPStan\Testing\assertType;

$logManager = resolve(LogManager::class);
$logManager->extend('emergency', function (): void {
assertType('Illuminate\Log\LogManager', $this);
});
11 changes: 11 additions & 0 deletions types/Managers/MailManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);


use Illuminate\Mail\MailManager;
use function PHPStan\Testing\assertType;

$mailManager = resolve(MailManager::class);
$mailManager->extend('symfony', function (): void {
assertType('Illuminate\Mail\MailManager', $this);
});
11 changes: 11 additions & 0 deletions types/Managers/QueueManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);


use Illuminate\Queue\QueueManager;
use function PHPStan\Testing\assertType;

$queueManager = resolve(QueueManager::class);
$queueManager->extend('custom', function (): void {
assertType('Illuminate\Queue\QueueManager', $this);
});
11 changes: 11 additions & 0 deletions types/Managers/RedisManager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);


use Illuminate\Redis\RedisManager;
use function PHPStan\Testing\assertType;

$redisManager = resolve(RedisManager::class);
$redisManager->extend('custom', function (): void {
assertType('Illuminate\Redis\RedisManager', $this);
});
Loading