Skip to content

Adds deprecation warning for usage of future non-default parsing extensions #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2021

Conversation

joelgallant
Copy link
Contributor

@joelgallant joelgallant commented May 2, 2021

…ions

NOTE that '$git' directive is currently incompatible with being included twice
@cypress
Copy link

cypress bot commented May 2, 2021



Test summary

17 0 0 0


Run details

Project App Config
Status Passed
Commit e1318c6
Started May 2, 2021 1:10 AM
Ended May 2, 2021 1:13 AM
Duration 02:33 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021

Codecov Report

Merging #150 (e1318c6) into master (1912747) will decrease coverage by 0.17%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   80.51%   80.34%   -0.18%     
==========================================
  Files          42       42              
  Lines        2366     2391      +25     
  Branches      558      569      +11     
==========================================
+ Hits         1905     1921      +16     
- Misses        461      470       +9     
Impacted Files Coverage Δ
app-config-v1-compat/src/index.ts 51.02% <22.22%> (-8.08%) ⬇️
app-config-git/src/index.ts 62.50% <75.00%> (-1.39%) ⬇️
app-config-encryption/src/index.ts 93.75% <80.00%> (-6.25%) ⬇️
app-config-extensions/src/substitute-directive.ts 97.80% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1912747...e1318c6. Read the comment docs.

@joelgallant joelgallant marked this pull request as ready for review May 2, 2021 01:16
@joelgallant joelgallant merged commit 816d6d4 into master May 2, 2021
@joelgallant joelgallant deleted the v3-deprecation-warnings branch May 2, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants