Fix H5P resources not showing completion when all questions answered correctly #13137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow completion to be triggered by 'answered' event.
Build Artifacts
|
There was a problem hiding this comment.
Code changes all LGTM. I see that you pinged @pcenov & @radinamatic on Slack w/ a channel for the testing so I'll leave final approval to them.
One question that comes to mind - what are the other consequences of removing it from the debounced verbs list? Is it just getting spammy logs in the console or something?
|
The main possible downside is more data in the extra fields. I think we can assume it will be OK unless we get reports otherwise. |
pcenov
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
answeredevent which we were not previously handling for triggering completionresult.completionset to true.References
Fixes #13010
Reviewer guidance
I don't think we've seen this in the QA channel, as I think older H5P resources didn't use this specific event. I will share the channel_id on slack for testing this.