-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
…s/less.js#895 Also some minor amends to make use of color functions a bit clearer.
First draft of reference docs
|
Remove testing doc
No idea! This has some bearing on my question about where these docs should go.
I've done that in my fork.
The docs include the hsv functions which I don't think have been pulled in yet, and they are missing the docs on color blending functions that Rubens said he was doing. Otherwise yes. This morning I did a load of testing and changes to make sure that the examples actually do what they say and I think it's now complete apart from those two things. Looking in functions.js makes me think that we're not very consistent in how percentages are handled, should probably add some more test cases. |
I'm wondering whether the functions section should be removed entirely and should link to a new page which has your reference information in them? Or maybe cut down to one or two examples and then link to your pages? Will you do a new pull request with the changes you mention or shall I take this one first? |
Not quite sure what you mean about the functions section? Take this pull first, other changes can come later. My only reservation is that the blend modes have placeholder titles but no content. Are you happy for me to pull #918 so the HSV docs are then true? |
Did the fade definition change? |
No? |
Ok, never mind. Hey, was poking at the new code in 1.3.1 today. Is there a reason the default threshold on the new contrast function appears to be 0.43? |
I think I got that from SASS, no idea why it was chosen as their default. |
I'll look at hsv next and pull it. This is pulled.. although until reference is referenced its invisble.. |
Document new color functions introduced in #730 and #803 in less.js.
Also some minor amends to make use of color functions a bit clearer and safer - applying spin to a grey value will do nothing because it has no saturation, so any hue value will be lost in the conversion back to RGB. This has been a source of support issues.