Skip to content

refactor: Remove app package files from knip ignore and fix unused code #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const SettingsTabSchema = union([

export type SettingsTabValue = InferOutput<typeof SettingsTabSchema>

export interface SettingsTab {
interface SettingsTab {
value: SettingsTabValue
label: string
icon: typeof BookMarked
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getFileContent } from '@liam-hq/github'
import { getProjectRepository } from './getProjectRepository'

export interface DocumentContentParams {
interface DocumentContentParams {
projectId: string
branchOrCommit: string
docFilePath: string[]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createClient } from '@/libs/db/server'

export interface ProjectRepository {
interface ProjectRepository {
repository: {
name: string
owner: string
Expand Down
6 changes: 3 additions & 3 deletions frontend/apps/app/components/AppBar/AppBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@ export interface Project {
name: string
}

export interface ProjectsList {
interface ProjectsList {
projects: Project[]
onProjectSelect: (project: Project) => void
onAddNewProject?: () => void
}

// Define a simple Branch interface that matches BranchItem
export interface Branch {
interface Branch {
id: string
name: string
tag?: string
}

export interface BranchesList {
interface BranchesList {
branches: Branch[]
onBranchSelect: (branch: Branch) => void
}
Expand Down
1 change: 0 additions & 1 deletion frontend/apps/app/components/AppBar/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ import { Check, GitBranch } from '@liam-hq/ui/src/icons'
import type { ComponentProps } from 'react'
import styles from './BranchDropdown.module.css'

export interface BranchItem {
interface BranchItem {
id: string
name: string
tag?: string
}

export interface BranchDropdownProps extends ComponentProps<'div'> {
interface BranchDropdownProps extends ComponentProps<'div'> {
branches: BranchItem[]
selectedBranchId?: string | undefined
onBranchSelect: (branch: BranchItem) => void
Expand Down
1 change: 0 additions & 1 deletion frontend/apps/app/components/BranchDropdown/index.ts

This file was deleted.

4 changes: 2 additions & 2 deletions frontend/apps/app/components/DiffCount/DiffCount.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import type { FC } from 'react'
import styles from './DiffCount.module.css'

export type DiffCountVariant = 'new' | 'delete'
type DiffCountVariant = 'new' | 'delete'

export interface DiffCountProps {
interface DiffCountProps {
count: number
variant: DiffCountVariant
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/apps/app/components/DiffCount/DiffCounts.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { DiffCount } from '@/components/DiffCount'
import type { FC } from 'react'
import styles from './DiffCounts.module.css'

export interface DiffCountsProps {
interface DiffCountsProps {
additions: number
deletions: number
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ import { Check, Plus } from '@liam-hq/ui/src/icons'
import type { ComponentProps } from 'react'
import { ProjectIcon } from '../ProjectIcon'
import styles from './ProjectsDropdown.module.css'
export interface ProjectItem {
interface ProjectItem {
id: string
name: string
}

export interface ProjectsDropdownProps extends ComponentProps<'div'> {
interface ProjectsDropdownProps extends ComponentProps<'div'> {
projects: ProjectItem[]
selectedProjectId?: string | undefined
onProjectSelect: (project: ProjectItem) => void
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { useMemo } from 'react'
import styles from './RadarChart.module.css'

export const categoryEnum = {
const categoryEnum = {
MIGRATION_SAFETY: 'MIGRATION_SAFETY',
DATA_INTEGRITY: 'DATA_INTEGRITY',
PERFORMANCE_IMPACT: 'PERFORMANCE_IMPACT',
Expand All @@ -13,7 +13,7 @@ export const categoryEnum = {

export type CategoryEnum = (typeof categoryEnum)[keyof typeof categoryEnum]

export type ReviewScore = {
type ReviewScore = {
id: string
overallReviewId: string
overallScore: number
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

import type { CategoryEnum } from '../components/RadarChart/RadarChart'

export type ReviewFeedbackForScore = {
type ReviewFeedbackForScore = {
category: string
severity: string
resolvedAt?: string | null
}

export type CalculatedScore = {
type CalculatedScore = {
id: string
overallReviewId: string
overallScore: number
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { createClient } from '@/libs/db/server'

export type CreateOrganizationResult =
type CreateOrganizationResult =
| { success: true; organizationId: string }
| { success: false; error: string }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from './organizationActions'

// Type definition for action state
export type ActionState =
type ActionState =
| { success: false; error: string; message?: undefined }
| { success: true; message: string; error?: undefined }
| { success: false; error: null; message: null }
Expand Down
Loading
Loading