-
Notifications
You must be signed in to change notification settings - Fork 140
💄 Adjust ERDEditor height to fill remaining available space #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Issue
N/A
Why is this change needed?
The height of the ERDEditor on the Schema page was set to 100dvh, which caused the bottom part—including the toolbar—to be cut off and not visible.
I adjusted the height of the ERDEditor to fill the remaining space after rendering components like the AppBar and ProjectHeader.
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at c9656f8
Detailed Changes
layout.module.css
Refactor project layout to use grid and improve tab sizing
frontend/apps/app/app/(app)/app/projects/[projectId]/layout.module.css
.container
from flex to grid for better layout controlgrid-template-rows
toauto 1fr
for header/content separation.tabContent
to usemin-height: 0
for proper overflow.tabContent
SchemaPage.module.css
Add and update styles for schema page tab content
frontend/apps/app/features/schemas/pages/SchemaPage/SchemaPage.module.css
.tabsContent
class withmin-height: 0
for tab contentERDEditor.module.css
Add dedicated wrapper styles for ERDEditor component
frontend/apps/app/features/schemas/pages/SchemaPage/components/ERDEditor/ERDEditor.module.css
.wrapper
class for ERDEditorposition: relative
andheight: 100%
for full height usagelayout.tsx
Refactor layout to use TabsRoot as main container
frontend/apps/app/app/(app)/app/projects/[projectId]/layout.tsx
SchemaPage.tsx
Apply new tab content styles for SchemaPage tabs
frontend/apps/app/features/schemas/pages/SchemaPage/SchemaPage.tsx
tabsContent
class to TabsContent componentsERDEditor.tsx
Use wrapper class for ERDEditor container styling
frontend/apps/app/features/schemas/pages/SchemaPage/components/ERDEditor/ERDEditor.tsx
.wrapper
class for ERDEditor containerAdditional Notes