Fix Guava compatibility issues and flaky tests #648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
commented
Jun 7, 2017
valfirst
commented
- Replace usage of deprecated c.g.c.n.HostAndPort.getHostText with HostAndPort.getHost (fix On Guava 22: NoSuchMethodError: com.google.common.net.HostAndPort.fromHost #638)
- Fix flaky tests: use nanoseconds instead of milliseconds
- Use login.newrelic.com because rpm.newrelic.com requires authentication now
- Replace msn.com with msn.com/en-us/ to avoid redirection
…AndPort.getHost com.google.common.net.HostAndPort.getHostText is removed in Guava 22.0, so usage of deprecated API causes runtime errors
Operations may take less than 1 millisecond at powerful machines, so rounding to milliseconds results to 0 time duration. Usage of nanoseconds allows to make tests more stable
Redirection leads to an extra page in Har and as result to failing tests. Change of URL allows to avoid redirection and tests work as expected.
This was referenced Jul 16, 2017
|
Thanks, @valfirst! Very good improvements here. I split this PR into a couple different PRs and cherry-picked some of your commits (#666, #668, #669). I went a step further with the legacy HarTest fixes and simply removed those tests completely; having tests that rely on third-party websites is extremely brittle. Since the essence of this PR has now been implemented in the above-mentioned PRs, I'll close this one. Thanks again for this! I'll get a release out with the guava fixes very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.