multi: announce Keysend feature bit #6414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we add the keysend feature bit to our NodeAnnouncement if the accept-keysend option is set.
ellemouton
commented
Apr 14, 2022
| @@ -529,6 +529,7 @@ func newServer(cfg *Config, listenAddrs []net.Addr, | |||
| NoAnchors: cfg.ProtocolOptions.NoAnchorCommitments(), | |||
| NoWumbo: !cfg.ProtocolOptions.Wumbo(), | |||
| NoScriptEnforcementLease: cfg.ProtocolOptions.NoScriptEnforcementLease(), | |||
| NoKeysend: !cfg.AcceptKeySend, | |||
There was a problem hiding this comment.
i've opted to just using the existing config option rather than moving it to the ProtocolOptions struct since that would break the API which i dont think is worth it for this change. but happy to change it if reviewers disagree!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add the keysend feature bit to our NodeAnnouncement
if the accept-keysend option is set.
Fixes #5044
Note that since many nodes out there currently support keysend without signalling for the feature bit, I think we should (for now at least) not require the optional feature bit before sending a keyspend payment to the peer. This mimics CL's behaviour too: ElementsProject/lightning@8252ac5
When majority of nodes start announcing the bit, we can make this more strict in order to not unnecessarily lock up liquidity