-
Notifications
You must be signed in to change notification settings - Fork 659
Fix: resize GuestOS disk #3437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: resize GuestOS disk #3437
Conversation
b3f95e5
to
a0800cf
Compare
a0800cf
to
baaa08f
Compare
baaa08f
to
e794dd0
Compare
This implementation works fine for increasing the disk size. |
Needs rebase |
Summary of Latest Review:
|
Note that #3513 moved the |
Signed-off-by: Songpon Srisawai <songpon.ssw@gmail.com>
c66a11a
to
538d26f
Compare
|
||
// store.Inspect() syncs values between inst.YAML and the store. | ||
// This call applies the validated template to the store. | ||
inst, err = store.Inspect(inst.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x104ceed71]
goroutine 1 [running]:
main.editAction(0xc0005acf08, {0xc0000ce960?, 0x4?, 0x104d7fff4?})
/Users/runner/work/lima/lima/cmd/limactl/edit.go:139 +0x731
github.com/spf13/cobra.(*Command).execute(0xc0005acf08, {0xc0000ce910, 0x5, 0x5})
/Users/runner/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1015 +0xa94
github.com/spf13/cobra.(*Command).ExecuteC(0xc00059c008)
/Users/runner/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1148 +0x40c
github.com/spf13/cobra.(*Command).Execute(...)
/Users/runner/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1071
main.main()
/Users/runner/work/lima/lima/cmd/limactl/main.go:41 +0x18
https://github.com/lima-vm/lima/actions/runs/14946273265/job/41989994774?pr=3437
Try to fix: #1448
How Lima edit disk
limactl edit
updates the disk value to the store. It does not resize disk image. Users have to manually resize byqemu-img
What I did
limactl disk add
command to add an existing qcow2 disk to Lima.diffdisk
of the instance to Lima, resize, and delete.