Makefile: split lima-additional-guestagents-*.tar.gz from lima-*.tar.gz #3503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
commented
May 7, 2025
AkihiroSuda
force-pushed
the
fix-3321
branch
2 times, most recently
from
756a491 to
51a193b
Compare
Merged
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
`make artifact` now produces two archives that will be uploaded to <https://github.com/lima-vm/lima/releases>: 1. lima-<VERSION>-Darwin-arm64.tar.gz: (`make native`) - core components (bin/limactl, share/lima/templates, ...) - share/lima/lima-guestagent.Linux-aarch64 2. lima-additional-guestagents-<VERSION>-Darwin-arm64.tar.gz: (`make additional-guestagents`) - share/lima/lima-guestagent.Linux-armv7l - share/lima/lima-guestagent.Linux-ppc64le - share/lima/lima-guestagent.Linux-riscv64 - share/lima/lima-guestagent.Linux-s390x - share/lima/lima-guestagent.Linux-x86_64 For compatibility reason, `make` still builds the guestagents for all the architectures by default. Package maintainers are suggested to split `lima` package to `lima` and `lima-additional-guestagents`. Fix issue 3321 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
Will release v1.1 RC after merging this cc @lima-vm/committers |
jandubois
approved these changes
May 12, 2025
There was a problem hiding this comment.
Seems ok to me.
But honestly, I find the Makefile is getting increasingly unreadable and I wonder if it would be better if it was replaced by a couple of build scripts.
We don't really make use of dependency management; rebuilding everything from scratch is typically just as fast anyways.
| @@ -140,7 +140,7 @@ exe: _output/bin/limactl$(exe) | |||
|
|
|||
| .PHONY: minimal native | |||
| minimal: clean limactl native-guestagent default_template | |||
| native: clean limactl helpers native-guestagent templates | |||
| native: clean limactl helpers native-guestagent templates template_experimentals | |||
There was a problem hiding this comment.
This (changing native target to include experimental templates) is not covered by the PR description, but I agree with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make artifactnow produces two archives that will be uploaded to https://github.com/lima-vm/lima/releases:lima-<VERSION>-Darwin-arm64.tar.gz: (make native)lima-additional-guestagents-<VERSION>-Darwin-arm64.tar.gz: (make additional-guestagents)For compatibility reason,
makestill builds the guestagents for all the architectures by default.Package maintainers are suggested to split
limapackage tolimaandlima-additional-guestagents.Fix #3321