Auto number of worker processes #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows NGINX to better take advantage of multiple cores, or tune down in constrained environments
|
Our stance has not changed since your last pr. We're not going to risk breaking numerous downstream images for something user configured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Set the number workers automatically based on the number of available cores.
Benefits of this PR and context:
This allows NGINX to better take advantage of multiple cores, or tune down in constrained environments.
A re-implementation of #53, without the connections change. Hoping re-opening the PR re-opens the discussion.
How Has This Been Tested?
Source / References:
https://nginx.org/en/docs/ngx_core_module.html#worker_processes