[RTG] Add tuple operations #8370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an immediate type and attribute that support any bitwidth and will replace the immediate types and attributes in the RTGTest dialect. Also adds a constant operation that can create an SSA value for any typed attribute. I also moved the labels type to form a kind of ISA subdialect with the immediates and made that explicit in the textual IR. We can do the same for relevant ops in the future.
This is a first implementation for if-statements and for/foreach-loops. We probably want to iterate on that because the stack frame manipulations and accessing is not great.
Initially the idea was to use the index dialect for arithmetic because it is smaller and simpler (doesn't accept any kind of shape types that we have to error out for, etc.). However, the SCF dialect depends on arith and its canonicalizers produce arith ops. The easiest solution to properly support if-statements and for loops in RTG is thus to just add support for arith ops that can be produced by those canonicalizers to the elaboration pass.
maerhart
force-pushed
the
maerhart-pyrtg-random-integer
branch
from
4747ca8 to
0d1e07d
Compare
rwy7
reviewed
Apr 16, 2025
| SmallVectorImpl<Type> &inferredReturnTypes) { | ||
| if (operands.empty()) { | ||
| if (loc) | ||
| return mlir::emitError(*loc) << "empty tuples not allowed"; |
There was a problem hiding this comment.
What's the reason for disallowing empty tuples?
youngar
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.