[Analysis] Ensure use of strict fp exceptions in ConstantFolding

[pratlucas]

To perform constant folding in math operations, the implementation of
the ConstantFolding Analysis relies on the use of the math functions
from the host's libm. In particular, it relies on checking the value of
errno and IEEE exceptions to determine when an operation is safe to be
constant-folded.

On some platforms, such as BSD or Darwin, math library functions don't
set errno, so the ConstantFolding check depends only on the value of
IEEE exceptions. As the FP exception behaviour is set to ignore by
default, the compiler can perform optimisations that would get in the
way of such checks being performed correctly.

This patch sets the FP exception behaviour to strict when compiling
the ConstantFolding.cpp source file, ensuring the value of IEEE
exceptions can be reliably used by its implementation.

[llvmbot]

@llvm/pr-subscribers-llvm-analysis

Author: Lucas Duarte Prates (pratlucas)

Changes

To perform constant folding in math operations, the implementation of
the ConstantFolding Analysis relies on the use of the math functions
from the host's libm. In particular, it relies on checking the value of
errno and IEEE exceptions to determine when an operation is safe to be
constant-folded.

On some platforms, such as BSD or Darwin, math library functions don't
set errno, so the ConstantFolding check depends only on the value of
IEEE exceptions. As the FP exception behaviour is set to ignore by
default, the compiler can perform optimisations that would get in the
way of such checks being performed correctly.

This patch sets the FP exception behaviour to strict when compiling
the ConstantFolding.cpp source file, ensuring the value of IEEE
exceptions can be reliably used by its implementation.

---

Full diff: https://github.com/llvm/llvm-project/pull/136139.diff

1 Files Affected:

• (modified) llvm/lib/Analysis/CMakeLists.txt (+11)

diff --git a/llvm/lib/Analysis/CMakeLists.txt b/llvm/lib/Analysis/CMakeLists.txt
index fbf3b587d6bd2..a37f088359c64 100644
--- a/llvm/lib/Analysis/CMakeLists.txt
+++ b/llvm/lib/Analysis/CMakeLists.txt
@@ -23,6 +23,17 @@ if (DEFINED LLVM_HAVE_TF_AOT OR LLVM_HAVE_TFLITE)
   endif()
 endif()
 
+# The implementaiton of ConstantFolding.cpp relies on the use of math functions
+# from the host. In particular, it relies on the detection of floating point
+# exceptions originating from such math functions to prevent invalid cases
+# from being constant folded. Therefore, we must ensure that fp exceptions are
+# handled correctly.
+if (MSVC)
+  set_source_files_properties(ConstantFolding.cpp PROPERTIES COMPILE_OPTIONS "/fp:except")
+else()
+  set_source_files_properties(ConstantFolding.cpp PROPERTIES COMPILE_OPTIONS "-ffp-exception-behavior=strict")
+endif()
+
 add_llvm_component_library(LLVMAnalysis
   AliasAnalysis.cpp
   AliasAnalysisEvaluator.cpp

[statham-arm]

I agree with the general idea, but I have a nit in the details.

(Also, today I learned you could use set_source_files_properties to change the build options for one file without creating a separate whole target, thank you!)

[statham-arm]

LGTM, but as usual, please give other reviewers time to comment.

[antoniofrighetto]

Suggested change

	# The implementaiton of ConstantFolding.cpp relies on the use of math functions
	# The implementation of ConstantFolding.cpp relies on the use of math functions