[CLANGD] [NFC] Fix proposed by static analyzer.

[zahiraam]

This fixes an issue reported by the sanitizer with the following error message:
copy_constructor_call: IndexOpts is passed by value as a parameter to clang::index::IndexingOptions::IndexingOptions instead of being moved.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clangd

Author: Zahira Ammarguellat (zahiraam)

Changes

This fixes an issue reported by the sanitizer with the following error message:
copy_constructor_call: IndexOpts is passed by value as a parameter to clang::index::IndexingOptions::IndexingOptions instead of being moved.

---

Full diff: https://github.com/llvm/llvm-project/pull/140116.diff

1 Files Affected:

• (modified) clang-tools-extra/clangd/index/FileIndex.cpp (+2-1)

diff --git a/clang-tools-extra/clangd/index/FileIndex.cpp b/clang-tools-extra/clangd/index/FileIndex.cpp
index 0fe069783d64f..c49de377d54ca 100644
--- a/clang-tools-extra/clangd/index/FileIndex.cpp
+++ b/clang-tools-extra/clangd/index/FileIndex.cpp
@@ -79,7 +79,8 @@ SlabTuple indexSymbols(ASTContext &AST, Preprocessor &PP,
 
   SymbolCollector Collector(std::move(CollectorOpts));
   Collector.setPreprocessor(PP);
-  index::indexTopLevelDecls(AST, PP, DeclsToIndex, Collector, IndexOpts);
+  index::indexTopLevelDecls(AST, PP, DeclsToIndex, Collector,
+                            std::move(IndexOpts));
   if (MacroRefsToIndex)
     Collector.handleMacros(*MacroRefsToIndex);
 

[nicovank]

LGTM!

AFAICT in this case this won't make an immediate performance difference since fields in this struct are primitives, but may in the future if the struct changes. This probably won't trigger performance-move-const-arg because of the std::function field where IIRC copying can be expensive in some cases when capturing variables.

[carlosgalvezp]

LGTM.

In the future, please provide more details about exactly which tool you are using, which you call "sanitizer". For example, what is the name of the tool?

"sanitizers" are tools to detect issues at runtime; here you are using a static analyzer.