-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[RISCV] Move slide and gather costing to subtarget [NFC] #65396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As discussed during review of D159332. This PR doesn't actually common up that copy of the code because doing so is not NFC - due to DLEN. Fixing that will be a future PR.
Where was this discussed in D159332? Why do we want this in Subtarget? Seems weird to start bring InstructionCost into Subtarget. |
|
Yes. That's the best place I can think of right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As mentioned in TODOs from D159332. This PR doesn't actually common up that copy of the code because doing so is not NFC - due to DLEN. Fixing that will be a future PR.
Landed as:
|
As discussed during review of D159332. This PR doesn't actually common up that copy of the code because doing so is not NFC - due to DLEN. Fixing that will be a future PR.