Skip to content

[libc][bazel] Fix missing dependencies for lseek #65618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

gchatelet
Copy link
Contributor

Failure introduced in 8cd4ecf

@gchatelet gchatelet requested a review from a team as a code owner September 7, 2023 15:09
@gchatelet gchatelet self-assigned this Sep 7, 2023
@github-actions github-actions bot added the libc label Sep 7, 2023
@gchatelet gchatelet removed their assignment Sep 7, 2023
@gchatelet
Copy link
Contributor Author

@mikhailramalho this is FYI, I'll submit this patch to restore bazel build.
You can monitor the state of the bazel build here https://buildkite.com/llvm-project/upstream-bazel

@gchatelet gchatelet merged commit 8d18671 into llvm:main Sep 7, 2023
@gchatelet gchatelet deleted the fix_bazel branch September 7, 2023 15:11
@mikhailramalho
Copy link
Member

Weird that I didn't get any emails about this PR or the mention, it was only on the github notifications for some reason.

Anyway, I'll keep an eye out for my changes to cmake from now on, I didn't know we had to also support bazel... I never used it tbh.

I'm assuming PR #65383 also breaks compilation with bazel?

@michaelrj-google
Copy link
Contributor

Bazel is considered a secondary build system for libc. We use the Bazel files at Google but they don't support all of the functions, features, and modes that the cmake files do.

You really only need to worry about Bazel when you're adding a new dependency to a file. Bazel is a lot more strict about includes than cmake.

Generally to test the bazel I use the following command from the folder llvm-project/utils/bazel:

bazel query @llvm-project//libc/... | xargs bazel test --config=generic_clang --test_output=errors --test_tag_filters=-nobuildkite --build_tag_filters=-nobuildkite --@llvm-project//libc:mpfr=system

I have that as part of my test script that I use to run all the tests before I land.

avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants