[Clang][LoongArch] Generate _mcount instead of mcount #65657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the LoongArch Linux kernel without CONFIG_DYNAMIC_FTRACE, the build fails to link because the mcount symbol is "mcount", not "_mcount" like GCC generates and the kernel expects: ld.lld: error: undefined symbol: mcount >>> referenced by version.c >>> init/version.o:(early_hostname) in archive vmlinux.a >>> referenced by do_mounts.c >>> init/do_mounts.o:(rootfs_init_fs_context) in archive vmlinux.a >>> referenced by main.c >>> init/main.o:(__traceiter_initcall_level) in archive vmlinux.a >>> referenced 97011 more times >>> did you mean: _mcount >>> defined in: vmlinux.a(arch/loongarch/kernel/mcount.o) Set MCountName in LoongArchTargetInfo to "_mcount", which resolves the build failure.
github-actions
bot
added
clang:frontend
|
cc @xen0n |
|
also cc @SixWeining (BTW we want to have a GitHub team set up for notifications and assignments apparently) It's 4 am here and I'd take a look after getting some sleep, to ensure review quality ;-) |
There is one: I will invite you to join this team and others interested in could also request to join. EDIT: Seems that you should request to join the |
SixWeining
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the LoongArch Linux kernel without
CONFIG_DYNAMIC_FTRACE, the build fails to link because the mcount symbol ismcount, not_mcountlike GCC generates and the kernel expects:Set
MCountNameinLoongArchTargetInfoto_mcount, which resolves the build failure.