Skip to content

[mlir][complex] Support fastmath in the binary op conversion. #65702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

[mlir][complex] Support fastmath in the binary op conversion. #65702

merged 1 commit into from
Sep 11, 2023

Conversation

Lewuathe
Copy link
Member

@Lewuathe Lewuathe commented Sep 8, 2023

Complex dialect arithmetic operations are now able to recognize the given fastmath flags. This PR lets the conversion from complex to standard keep the fastmath flag passed to arith dialect ops.

See:
https://discourse.llvm.org/t/rfc-fastmath-flags-support-in-complex-dialect/71981

@Lewuathe
[mlir][complex] Support fastmath in the binary op conversion.
c471f8f 
Complex dialect arithmetic operations are now able to recognize the
given fastmath flags. This PR lets the conversion from complex to
standard keep the fastmath flag passed to arith dialect ops.

See:
https://discourse.llvm.org/t/rfc-fastmath-flags-support-in-complex-dialect/71981
@Lewuathe Lewuathe requested a review from a team as a code owner September 8, 2023 00:43
@github-actions github-actions bot added the mlir label Sep 8, 2023
@Lewuathe Lewuathe closed this Sep 11, 2023
@Lewuathe Lewuathe reopened this Sep 11, 2023
@Lewuathe
Copy link
Member Author

Are we apparently running out of heap space?

C:\BuildTools\VC\Tools\MSVC\14.29.30133\include\variant(1652): fatal error C1060: compiler is out of heap space

@joker-eph
Copy link
Collaborator

Are we apparently running out of heap space?
C:\BuildTools\VC\Tools\MSVC\14.29.30133\include\variant(1652): fatal error C1060: compiler is out of heap space

@metaflow FYI ^

@Lewuathe
Copy link
Member Author

@joker-eph Thank you for approving this PR. The CI failure seems temporary, but I have no permission to retry the build. How can we re-run the CI job to ensure the test passes?

@joker-eph
Copy link
Collaborator

In general rebasing and pushing would re-trigger the CI. But really I wouldn't bother too much for such a change: if it passes locally it seems low risk to merge.

@Lewuathe
Copy link
Member Author

@joker-eph Thanks for the advice. I'll merge this as I confirmed it has passed the test in local.

@Lewuathe Lewuathe merged commit be5b666 into llvm:main Sep 11, 2023
@Lewuathe Lewuathe deleted the fastmath-for-complex-add branch September 11, 2023 06:57
@metaflow
Copy link
Contributor

@joker-eph running out of heap space seems strange - agents have 100Gb+ RAM. Could it be due to parallelism or wrong configuration flags?

@michaelrj-google michaelrj-google mentioned this pull request Sep 12, 2023
Merged
@vzakhari vzakhari mentioned this pull request Sep 12, 2023
Closed
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
@Lewuathe @ZijunZhaoCCK
[mlir][complex] Support fastmath in the binary op conversion. (llvm#6…
f90e547 
…5702)

Complex dialect arithmetic operations are now able to recognize the
given fastmath flags. This PR lets the conversion from complex to
standard keep the fastmath flag passed to arith dialect ops.

See:

https://discourse.llvm.org/t/rfc-fastmath-flags-support-in-complex-dialect/71981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker-eph joker-eph joker-eph approved these changes

Assignees
No one assigned
Labels
mlir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lewuathe @joker-eph @metaflow