[mlir][vector] Extend mask calculation for vector.contract #65733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banach-space
requested review from
c-rhodes,
jsetoain,
nicolasvasilache,
dcaballe and
MacDue
jsetoain
approved these changes
Sep 8, 2023
dcaballe
approved these changes
Sep 11, 2023
c-rhodes
reviewed
Sep 11, 2023
mlir/test/Dialect/Vector/vector-contract-to-parallel-arith-transforms.mlir
Outdated
Show resolved
Hide resolved
Make sure that when calculating the expected mask for `vector.contract`, scalable sizes are correctly taken into account.
banach-space
force-pushed
the
andrzej/extend_mask_vector_contract
branch
from
77eec46 to
77b8395
Compare
c-rhodes
approved these changes
Sep 11, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Make sure that when calculating the expected mask for `vector.contract`, scalable sizes are correctly taken into account. Depends on: llvm#65724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that when calculating the expected mask for
vector.contract,scalable sizes are correctly taken into account.
Depends on: #65724