[AMDGPU] Mark S_NOP as having side effects #65745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents S_NOP from being rescheduled past other (side-effecting) instructions, which is useful because it is generally used to introduce a short delay or to avoid hazards. Currently this only affects MIR tests because the compiler itself only inserts nops in PostRAHazardRecognizer which runs after all scheduling.
jayfoad
commented
Sep 8, 2023
| @@ -63,9 +63,9 @@ body: | | |||
| ; CHECK-NEXT: {{ $}} | |||
| ; CHECK-NEXT: bb.1: | |||
| ; CHECK-NEXT: S_NOP 0, implicit %1.sub2 | |||
| ; CHECK-NEXT: S_NOP 0, implicit undef %4.sub0:vreg_128 | |||
There was a problem hiding this comment.
S_NOPs can't be reordered now, since they all have side effects.
jayfoad
commented
Sep 8, 2023
| @@ -343,9 +343,41 @@ body: | | |||
| ; GCN: bb.0: | |||
| ; GCN-NEXT: successors: %bb.1(0x80000000) | |||
| ; GCN-NEXT: {{ $}} | |||
| ; GCN-NEXT: S_NOP 0 | |||
There was a problem hiding this comment.
S_NOPs are no longer deleted by dead-mi-elimination.
jayfoad
commented
Sep 8, 2023
| @@ -72,8 +72,7 @@ | |||
| ; GFX908-NEXT: ; implicit-def: $vgpr59 | |||
| ; GFX908-NEXT: ; implicit-def: $vgpr60 | |||
| ; GFX908-NEXT: ; implicit-def: $vgpr61 | |||
| ; GFX908-NEXT: s_nop 0 | |||
| ; GFX908-NEXT: s_nop 0 | |||
| ; GFX908-NEXT: s_nop 1 | |||
There was a problem hiding this comment.
GCNHazardRecognizer wants to delay for 2 cycles here. If there was already an S_NOP 0 here it would add another one, instead of modifying it to be an S_NOP 1.
arsenm
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents S_NOP from being rescheduled past other (side-effecting)
instructions, which is useful because it is generally used to introduce
a short delay or to avoid hazards. Currently this only affects MIR tests
because the compiler itself only inserts nops in PostRAHazardRecognizer
which runs after all scheduling.