-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[Clang][RISCV] Use Decl for checkRVVTypeSupport #65778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add the test |
559c8a2
to
ebffa14
Compare
jrtc27
requested changes
Sep 8, 2023
ebffa14
to
8226aec
Compare
8226aec
to
90764ba
Compare
jrtc27
reviewed
Sep 8, 2023
Using ValueDecl will cause error for OpenMP. Decl should do the work.
90764ba
to
91e607d
Compare
@llvm/pr-subscribers-clang ChangesUsing ValueDecl will cause error for OpenMP. Decl should do the work.Full diff: https://github.com/llvm/llvm-project/pull/65778.diff 4 Files Affected:
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h index 4fd0e6bd5982a71..5c7207062741b52 100644 --- a/clang/include/clang/Sema/Sema.h +++ b/clang/include/clang/Sema/Sema.h @@ -13726,7 +13726,7 @@ class Sema final { bool CheckRISCVLMUL(CallExpr *TheCall, unsigned ArgNum); bool CheckRISCVBuiltinFunctionCall(const TargetInfo &TI, unsigned BuiltinID, CallExpr *TheCall); - void checkRVVTypeSupport(QualType Ty, SourceLocation Loc, ValueDecl *D); + void checkRVVTypeSupport(QualType Ty, SourceLocation Loc, Decl *D); bool CheckLoongArchBuiltinFunctionCall(const TargetInfo &TI, unsigned BuiltinID, CallExpr *TheCall); bool CheckWebAssemblyBuiltinFunctionCall(const TargetInfo &TI, diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index 3932d9cd07d9864..3b4ac613da76aa8 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -5514,7 +5514,7 @@ bool Sema::CheckWebAssemblyBuiltinFunctionCall(const TargetInfo &TI, return false; } -void Sema::checkRVVTypeSupport(QualType Ty, SourceLocation Loc, ValueDecl *D) { +void Sema::checkRVVTypeSupport(QualType Ty, SourceLocation Loc, Decl *D) { const TargetInfo &TI = Context.getTargetInfo(); // (ELEN, LMUL) pairs of (8, mf8), (16, mf4), (32, mf2), (64, m1) requires at // least zve64x diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index d6e090ee496eb30..37060f668b7acf3 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -8866,7 +8866,7 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) { } if (T->isRVVType()) - checkRVVTypeSupport(T, NewVD->getLocation(), cast(CurContext)); + checkRVVTypeSupport(T, NewVD->getLocation(), cast(CurContext)); } /// Perform semantic checking on a newly-created variable diff --git a/clang/test/SemaOpenMP/riscv-vector-with-openmp.c b/clang/test/SemaOpenMP/riscv-vector-with-openmp.c new file mode 100644 index 000000000000000..5dae3eb9ce0b0a2 --- /dev/null +++ b/clang/test/SemaOpenMP/riscv-vector-with-openmp.c @@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v -fsyntax-only \ +// RUN: -verify -fopenmp %s +// REQUIRES: riscv-registered-target + +// expected-no-diagnostics + +void foo() { + #pragma omp parallel + { + __rvv_int32m1_t i32m1; + } +} |
alexey-bataev
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
@jrtc27 Anymore comments before merging this? |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Using ValueDecl will cause error for OpenMP. Decl should do the work.
fanghuaqi
pushed a commit
to riscv-mcu/llvm-project
that referenced
this pull request
Oct 7, 2023
Using ValueDecl will cause error for OpenMP. Decl should do the work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend:RISC-V
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
clang
Clang issues not falling into any other category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ValueDecl will cause error for OpenMP. Decl should do the work.