Skip to content

[mlir][test][gpu] Migrate ROCM tests to the TargetAttr compilation workflow #65805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

fabianmcg
Copy link
Contributor

@fabianmcg fabianmcg commented Sep 8, 2023

Migrate tests referencing gpu-to-hsaco to the new compilation workflow using TargetAttrs.

The test Integration/GPU/ROCM/printf.mlir crashed when I tested on MI250x, however, it also crashes with gpu-to-hsaco.

…rkflow

Migrate tests referencing `gpu-to-hsaco` to the new compilation workflow using TargetAttrs.
@fabianmcg fabianmcg requested a review from joker-eph September 8, 2023 21:04
@fabianmcg fabianmcg requested a review from a team as a code owner September 8, 2023 21:04
@fabianmcg fabianmcg removed the request for review from a team September 8, 2023 21:06
@joker-eph
Copy link
Collaborator

Please fix the PR title (remove the annoying wrap from GitHub)

@fabianmcg fabianmcg changed the title [mlir][test][gpu] Migrate ROCM tests to the TargetAttr compilation wo… [mlir][test][gpu] Migrate ROCM tests to the TargetAttr compilation workflow Sep 9, 2023
@fabianmcg fabianmcg merged commit 5db8990 into llvm:main Sep 9, 2023
@fabianmcg fabianmcg deleted the rocm-tests branch September 9, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants