Skip to content

[libc][NFC] Make add_header_library rule support COMPILE_OPTIONS. #65821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

sivachandra
Copy link
Collaborator

The options added via COMPILE_OPTIONS will be treated as INTERFACE
options. This will help in setting compile options based on libc config
options in future patches.

The options added via COMPILE_OPTIONS will be treated as INTERFACE
options. This will help in setting compile options based on libc config
options in future patches.
@sivachandra sivachandra requested a review from lntue September 8, 2023 23:08
@sivachandra sivachandra requested a review from a team as a code owner September 8, 2023 23:08
@github-actions github-actions bot added the libc label Sep 8, 2023
Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sivachandra sivachandra merged commit b0068b5 into llvm:main Sep 9, 2023
@sivachandra sivachandra deleted the header_library_compile_options branch September 13, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants