Skip to content

[Fuchsia] Re-enable libcxx timezone database #65981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

abrachet
Copy link
Member

No description provided.

@abrachet abrachet requested a review from petrhosek September 11, 2023 17:06
@abrachet abrachet requested a review from a team as a code owner September 11, 2023 17:06
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 11, 2023
@llvmbot
Copy link
Member

llvmbot commented Sep 11, 2023

@llvm/pr-subscribers-clang

Changes

None

Full diff: https://github.com/llvm/llvm-project/pull/65981.diff

1 Files Affected:

  • (modified) clang/cmake/caches/Fuchsia-stage2.cmake (-3)
diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake
index 10e5cacf51c4b7b..4890040b1b6a2b4 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -181,9 +181,6 @@ foreach(target aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unkn
     set(RUNTIMES_${target}_LLVM_TOOLS_DIR "${CMAKE_BINARY_DIR}/bin" CACHE BOOL "")
     set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
 
-    # TODO: Remove this once #65859 lands.
-    set(RUNTIMES_${target}_LIBCXX_ENABLE_TIME_ZONE_DATABASE OFF CACHE STRING "")
-
     # Use .build-id link.
     list(APPEND RUNTIME_BUILD_ID_LINK "${target}")
   endif()

@abrachet abrachet merged commit 779a7b7 into llvm:main Sep 11, 2023
@abrachet abrachet deleted the re-enable-tzdb branch September 11, 2023 17:37
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants