[Pass][CodeGen] Add some necessary passes for codegen #70903
Conversation
| @@ -124,6 +122,8 @@ DUMMY_FUNCTION_PASS("cfguard-check", CFGuardCheckPass, ()) | |||
| DUMMY_FUNCTION_PASS("gc-info-printer", GCInfoPrinterPass, ()) | |||
| DUMMY_FUNCTION_PASS("select-optimize", SelectOptimizePass, ()) | |||
| DUMMY_FUNCTION_PASS("callbrprepare", CallBrPrepare, ()) | |||
| DUMMY_FUNCTION_PASS("expand-large-div-rem", ExpandLargeDivRemPass, ()) | |||
There was a problem hiding this comment.
What's the difference between FUNCTION_PASS and DUMMY_FUNCTION_PASS? Why do these need to move?
There was a problem hiding this comment.
DUMMY_* denotes this pass has not been ported to the new pass system, if they are ported to the new pass system, the DUMMY prefix should be removed. These codes are used by CodeGenPassBuilder.h to register necessary IR transformations/analyses.
I searched code base for these two passes, and found that ExpandLargeDivRemPass and ExpandLargeFpConvertPass are still legacy pass.
There was a problem hiding this comment.
Fixed ExpandLargeDivRem in #71022
paperchalice
force-pushed
the
NPM/CodeGen/Passes
branch
from
21c82a4 to
69e8157
Compare
|
Align with upstream. |
|
Hi @paperchalice it looks like this broke building LLVM with Modules enabled so I will be reverting shortly. Please take a look: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62369/console You can reproduce by trying to build llvm with the CMake setting |
This change broke building LLVM with Module support enabled, i.e. `LLVM_ENABLE_MODULES=ON`. This reverts commit f40da07.
These passes are used in
TargetPassConfig.cpp, so add them here. Part of #69879.@arsenm Thanks for reviwing.