[Pass] Add some missing passes #77600
Conversation
paperchalice
force-pushed
the
missing
branch
5 times, most recently
from
b9564fb to
857a975
Compare
llvm/lib/Passes/PassRegistry.def
Outdated
| @@ -142,6 +143,7 @@ MODULE_PASS("tsan-module", ModuleThreadSanitizerPass()) | |||
| MODULE_PASS("verify", VerifierPass()) | |||
| MODULE_PASS("view-callgraph", CallGraphViewerPass()) | |||
| MODULE_PASS("wholeprogramdevirt", WholeProgramDevirtPass()) | |||
| MODULE_PASS("write-bitcode", BitcodeWriterPass(nulls(), true)) | |||
There was a problem hiding this comment.
What's the point of including this here? The canonical way to use the bitcode writer pass seems to be to add it manually to the pipeline so whatever is using the pipeline can set it's own output stream (which is just set to null here, seeming to make the pass not really useful?).
There was a problem hiding this comment.
Yes, but when using opt -print-pipeline-passes foo.ll will report:
Could not parse dumped pass pipeline: unknown module pass 'BitcodeWriterPass'Or we can manually add this pass name in constructor.
There was a problem hiding this comment.
Add BitcodeWriterPass manually in constructor now.
There was a problem hiding this comment.
I'm assuming that error is from running the opt invocation with the textual representation of the pass pipeline from -print-pipeline-passes? What is your invocation to get the Bitcode Writer in the printed pass pipeline? That doesn't occur (for me) with ToT opt with something like opt -passes='default<O3>' -print-pipeline-passes test.ll for example.
There was a problem hiding this comment.
Oh, I forget the -o option. opt -passes='default<O3>' -print-pipeline-passes test.ll -o test.bc will print the error.
There was a problem hiding this comment.
Ah. I should've figured -disable-output on my invocation would never create the bitcode writer. I'm not convinced the current approach (currently manually calling addClassToPassName in the PassBuilder constructor) is best. Others probably have better ideas on the best approach to fix this.
There was a problem hiding this comment.
Test new-pm-print-pipeline.ll failed. It seems like this was done on purpose, will revert related change.
When dumping IR pipeline in unit test, these passes show their class names, so add them to pass builder to ensure all names are populated. Also, when invoke `opt -print-pipeline-passes` without `-S`, it will print: Could not parse dumped pass pipeline: unknown module pass 'BitcodeWriterPass'
When dumping IR pipeline in unit test of PR #77084, these passes show their class names, so add them to pass builder to ensure all names are populated.
Also, when invoke
opt -print-pipeline-passeswithout-S, it will print:Could not parse dumped pass pipeline: unknown module pass 'BitcodeWriterPass'