Reland "[CodeGen] Support start/stop in CodeGenPassBuilder (#70912)" #78570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused, |
Yes, but in unit test I use the option |
Add `-start/stop-before/after` support for CodeGenPassBuilder. Part of llvm#69879.
paperchalice
force-pushed
the
startstop
branch
from
fcb7de6 to
bd13755
Compare
|
Remove the workaround, old implementation and unit test, because we can test it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the legacy pass system can't recognize
no-op-moduleandno-op-functionso it causes test failure inCodeGenTests. Add a workaround in functionPassInfo *getPassInfo(StringRef PassName),TargetPassConfig.cpp.