Add value spans to clickbench tests, add docs and From impl #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 24, 2025
| #[derive(Debug, Clone, Eq, Ord)] | ||
| /// Wraps a primitive SQL [`Value`] with its [`Span`] location | ||
| /// | ||
| /// # Example: create a `ValueWithSpan` from a `Value` |
There was a problem hiding this comment.
I added some examples to make the transition easier
| } | ||
| } | ||
|
|
||
| impl Ord for ValueWithSpan { |
| @@ -63,6 +102,12 @@ impl From<ValueWithSpan> for Value { | |||
| } | |||
| } | |||
|
|
|||
| impl From<Value> for ValueWithSpan { | |||
There was a problem hiding this comment.
This makes it easy to create new ValueWithSpan
| @@ -55,7 +55,7 @@ fn parse_map_access_expr() { | |||
| "indexOf", | |||
| [ | |||
| Expr::Identifier(Ident::new("string_names")), | |||
| Expr::Value(Value::SingleQuotedString("endpoint".to_string())) | |||
| Expr::value(Value::SingleQuotedString("endpoint".to_string())) | |||
There was a problem hiding this comment.
By adding the Expr::value method, the changes to update the tests became a find/replace exercise
alamb
changed the title
|
Thanks for your help ! I manually merged your changes into apache#1738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR will update the above PR
I will comment inline