Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools,ipgen] Improve VLNV renaming #26540

Closed
matutem opened this issue Mar 6, 2025 · 0 comments · Fixed by #26541
Closed

[tools,ipgen] Improve VLNV renaming #26540

matutem opened this issue Mar 6, 2025 · 0 comments · Fixed by #26541

Comments

@matutem
Copy link
Contributor

matutem commented Mar 6, 2025

Description

IPGEN blocks have their fusesoc VLNV modified so they become top-specific. The renaming scheme needs to retain the information already existing in the VLNV and just add some extra tokens to uniquify the top-specific block. The current renaming scheme removes some information, like the library, and adds some irrelevant tokens, like 'opentitan'. In addition, we need stronger support for other block renaming needed to further uniquify block artifacts, essentially applying uniquified names to any core artifact.

matutem added a commit to matutem/opentitan that referenced this issue Mar 6, 2025
Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 6, 2025
Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 7, 2025
Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
VLNV scheme. This only needs the template name and the info in "self".
Remove the extra "prefix" parameter.
Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 7, 2025
Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
VLNV scheme. This only needs the template name and the info in "self".
Remove the extra "prefix" parameter.
Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 7, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 8, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 11, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
Update description of VLNV renaming and module uniquification.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
Update description of VLNV renaming and module uniquification.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
Update description of VLNV renaming and module uniquification.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
Update description of VLNV renaming and module uniquification.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit to matutem/opentitan that referenced this issue Mar 12, 2025
Update description of VLNV renaming and module uniquification.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem added a commit that referenced this issue Mar 13, 2025
Update description of VLNV renaming and module uniquification.

Fixes #26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
vogelpi pushed a commit to vogelpi/opentitan that referenced this issue Mar 21, 2025
- Change IpTemplateRendererBase._tplfunc_instance_vlnv per the new
  VLNV scheme. This only needs the template name and the info in "self".
  Remove the extra "prefix" parameter.
- Remove some unnecessary vlnv related ipgen parameters.
- Change top core files to use the new naming.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
vogelpi pushed a commit to vogelpi/opentitan that referenced this issue Mar 21, 2025
Update description of VLNV renaming and module uniquification.

Fixes lowRISC#26540

Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant