[rom] Switch keys SPX+ keys to OTP #22066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moidx
commented
Mar 16, 2024
moidx
commented
- Add sigverify config parameters to const.bzl so that they can be used in OTP config targets.
- Introduce OTP partitions for real and fake keys.
- Update OtpMemImg.py to enable code generation for ROT_AUTH OTP partitions. This will be used to enable the provisioning flows later.
Update the SW_WRITE_ALIGNMENT dictionary to capture the byte alignment properties of the `ROT_CREATOR_AUTH_CODESIGN` and `ROT_CREATOR_AUTH_STATE` partitions. Signed-off-by: Miguel Osorio <miguelosorio@google.com>
moidx
force-pushed
the
a1-rom-switch-spx-keys-to-otp
branch
2 times, most recently
from
94dea17 to
d73696f
Compare
Keys stored in OTP will have to be configured with constant values that are defined in the rom sigverify library. This change adds such constant definitions to //rules/const.bzl. In addition to this. The SPX+ config id enums were updated to use higher hamming distance values and to use a name reflecting the SPX+ parameter configuration. Signed-off-by: Miguel Osorio <miguelosorio@google.com>
This commit adds a fake keys build configuration for RoT keys. Signed-off-by: Miguel Osorio <miguelosorio@google.com>
This commit adds a placeholder for the real SPX+ keys based on the earlgrey_es_sival real key configuration. Signed-off-by: Miguel Osorio <miguelosorio@google.com>
moidx
force-pushed
the
a1-rom-switch-spx-keys-to-otp
branch
from
d73696f to
61fec85
Compare
timothytrippel
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.