-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[top_earlgrey,prim_ram_*_pkg] Connect memory test port #23547
Merged
moidx
merged 1 commit into
lowRISC:master
from
andreaskurth:top_earlgrey-connect-memory-test-port
Jun 10, 2024
Merged
[top_earlgrey,prim_ram_*_pkg] Connect memory test port #23547
moidx
merged 1 commit into
lowRISC:master
from
andreaskurth:top_earlgrey-connect-memory-test-port
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @andreaskurth !
This adds a memory test port and connects it to the AST interface added in PR lowRISC#23531. Signed-off-by: Andreas Kurth <adk@lowrisc.org>
7af60b0
to
25fc99d
Compare
meisnere
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this pull request
Jun 18, 2024
This is a follow-up of lowRISC#23547. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi
added a commit
that referenced
this pull request
Jun 18, 2024
This is a follow-up of #23547. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
antmarzam
pushed a commit
to antmarzam/opentitan
that referenced
this pull request
Jun 24, 2024
This is a follow-up of lowRISC#23547. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
AlexJones0
pushed a commit
to AlexJones0/opentitan
that referenced
this pull request
Jul 8, 2024
This is a follow-up of lowRISC#23547. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a memory test port and connects it to the AST interface added in PR #23531.