go.mod automatically updated

[tylerphelan]

We're noticing that our go.mod file gets updated if we open a session inside a go mod project. The packages added are:

+ golang.org/x/crypto v0.0.0-20190506204251-e1dfcc566284 // indirect
+ golang.org/x/net v0.0.0-20190503192946-f4e77d36d62c // indirect
+ golang.org/x/sys v0.0.0-20190507160741-ecd444e8653b // indirect
+ golang.org/x/text v0.3.2 // indirect
+ golang.org/x/tools v0.0.0-20190506145303-2d16b83fe98c // indirect

We think it has to do with installing vim-go with :InstallBinaries but we're not sure what's going on. When we set :let $GO111MODULE = 'off' in before.vim we don't get the updates to go.mod so it's trying to install something..

Have you seen behavior like this? Are we doing something wrong? Any help to get rid of the automatic go.mod updates would greatly appreciated!

[luan]

Do you have a minimal reproducible example repo I can play around with?

[Changdrew]

We think this happens because

nvim/update.vim

Lines 42 to 45 in 6c7522a

	function! update#installLanguageServers()
	if executable('go')
	call jobstart('go get -u golang.org/x/tools/cmd/gopls')
	endif

runs on opening any go file. With the change to go mod, go get does different things. We (@vitreuz) tried to turn off auto-update through let g:skip_autoupdate = 1 but that didn't disable the updating.

[vitreuz]

@luan here's an example repo

https://github.com/vitreuz/module-repro-bug

[luan]

@Changdrew that logic was added before vim-go actually started installing gopls. I removed it now.

This issue is now only going to happen when running a fresh :GoInstallBinaries or :GoUpdateBinaries from a go mod project. So the problem is still present on vim-go.

I'm still looking at how we can mitigate it on this repo though it should be a bit better now.

[luan]

Aand it looks like vim-go has actually already dealt with this.

I couldn't reproduce the problem with latest everything anymore so it seems like it may be fixed. Please re-open if this continues happening for you.