Update CI #450
Merged
Update CI #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
approved these changes
Feb 28, 2025
|
Thanks for taking the time to contribute. At some point we should review whether we should go back to leafo's version of the Lua GH actions or stick with the LuaRocks forks. The maintainer was MIA for a long time but I saw they finally got updated just today or very recently. That can wait a little while while we discuss which repo will be canonical going forward. |
|
Sure. I also saw leafo's action was updated. I even tried it, but I faced an issue trying to install the latest LuaRocks (it was not able to find 3.11.1 configure file). So, I decided to employ the one from luarocks acc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The proposed changes allow
luasocketto be tested on macOS.Changes
macos-14runner image, because the used version (macos-11) is not supported anymore. See the supported versions https://github.com/actions/runner-images/tree/main?tab=readme-ov-file#available-images.Notes
With the proposed changes,
luasocketCI is still failing onluajitandopenrestyon Windows. However, since this behavior was happening on Windows before this PR, it is unlikely that this failure was caused by the changes.