Outset 4.0.4 #32
Merged
Outset 4.0.4 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re login window tasks were executing continuously.
refactor sha256sum to checksum removed old preference definitions, some of which were being used in-code. Since these were never being populated they would not evaluate and conditional code was not being run as a result.
…rary/Preferences instead of /var/root/Library/Preferences. This fixes a bunch of expected behaviour like using `--add-ignored-user` and having it correctly apply to all users on the system and not just when run in a user context.
added some additional debug logging updated loadPreferences function to force load from `/Library/Preferences/io.macadmins.Outset.plist` if running as root update loginOnce processing to pass in any overrides. also added some extra debug logging to inform if the console user is in the ignored list
also keeping the linter happy.
…rences` and not to `/var/root/Library/Preferences` Added logic to migrateLegacyPreferences if they exist (issue in initial 4.0 to 4.0.2 using UserDefaults which results in preferences being written to `/var/root/Library/Preferences` which is problematic for settings that all users might need to access.
|
I just spammed a bunch of people for a review if anyone is available to take a look. If not, I'm happy to bypass branch protections and merge anyway but figure having someone look over is a good habit to get in to 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why not 4.0.3? Excellent question.
This release fixes a bunch of things.
LaunchOnlyOnceto login-window.plist/Library/Preferences/instead of/var/root/Library/Preferences/. Makes an attempt at moving settings saved in/var/root/over if the old preferences file is detected--compute-shais now--checksumadd-overideandremove-overideare nowadd-overrideandremove-overrideprefswere being read and resulting in an incorrect comparison