Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests to use jest #942

Merged
merged 26 commits into from
May 28, 2021
Merged

Migrate tests to use jest #942

merged 26 commits into from
May 28, 2021

Conversation

macbre
Copy link
Owner

@macbre macbre commented May 26, 2021 •
edited
Loading 

Test Suites: 14 passed, 14 total
Tests:       1 skipped, 481 passed, 482 total
Snapshots:   0 total
Time:        38.426 s

@macbre macbre added this to the v2.3 milestone May 26, 2021
@macbre macbre marked this pull request as ready for review May 27, 2021 15:50
@macbre macbre enabled auto-merge May 27, 2021 15:50
@macbre
Copy link
Owner Author

macbre commented May 28, 2021 •
edited
Loading

Tests do pass on Node.js 14.x, but fail on 15.x and 16.x - puppeteer is not installed there when executing npm ci...

It's npm v6 (14.x and above) vs v7 (15.x)+. https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json

macbre added 2 commits May 28, 2021 09:50
@macbre macbre merged commit c01a3ea into devel May 28, 2021
@macbre macbre deleted the jest branch May 28, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internals
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
1 participant
@macbre